Skip to content

fix: ts strict errors in paginationitem #3504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 3, 2023
Merged

Conversation

reesscot
Copy link
Contributor

@reesscot reesscot commented Mar 3, 2023

Description of changes

Fixes TS strict errors in PaginationItem component due to onClick possibly being undefined.

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are updated
  • No side effects or sideEffects field updated
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@reesscot reesscot requested a review from a team as a code owner March 3, 2023 22:10
@changeset-bot
Copy link

changeset-bot bot commented Mar 3, 2023

🦋 Changeset detected

Latest commit: f8e09d8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@aws-amplify/ui-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@reesscot reesscot enabled auto-merge (squash) March 3, 2023 22:15
@reesscot reesscot temporarily deployed to ci March 3, 2023 22:30 — with GitHub Actions Inactive
@reesscot reesscot temporarily deployed to ci March 3, 2023 22:30 — with GitHub Actions Inactive
@reesscot reesscot temporarily deployed to ci March 3, 2023 22:30 — with GitHub Actions Inactive
@reesscot reesscot temporarily deployed to ci March 3, 2023 22:30 — with GitHub Actions Inactive
@reesscot reesscot merged commit b4a2d19 into main Mar 3, 2023
@reesscot reesscot deleted the reesscot-ts-strict-12 branch March 3, 2023 23:42
This was referenced Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants