fix: update to use the old JSX transform #2513
Conversation
🦋 Changeset detectedLatest commit: 054dce2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
zchenwei
changed the title
zchenwei
changed the title
| @@ -8,6 +8,7 @@ const iconNames = []; | |||
|
|
|||
| const template = ({ iconName, source }) => { | |||
| return `import classNames from 'classnames'; | |||
| import * as React from 'react'; | |||
There was a problem hiding this comment.
The old transform will need React in scope so that why I added it in a few places
|
Thanks for handling this! Looks straightforward to me, but can you cherry pick the commit and test against in-app-messaging/main please? |
.changeset/rich-peas-try.md
Outdated
| "@aws-amplify/ui-react": patch | ||
| --- | ||
|
|
||
| fix: update to use the old JSX transform to support app running on React prior to 16.14.0 where the nex JSX transform does not get backported |
There was a problem hiding this comment.
ohhh, good catch I mean new
I test against that branch you mention in a sample app and it works good. For the build, since the old transform need React in scope, so anywhere you use JSX you will need to import React in the module and Rollup will hint you. There is only one place I can see you need to during my testing: |
| @@ -4,7 +4,7 @@ | |||
| "baseUrl": ".", | |||
| "declaration": true, | |||
| "esModuleInterop": true, | |||
| "jsx": "react-jsx", | |||
There was a problem hiding this comment.
For my knowledge, can you briefly explain why this had to be changed?
There was a problem hiding this comment.
This is controls how JSX constructs are emitted in JavaScript files. It has better details here <- https://www.typescriptlang.org/tsconfig#jsx
Description of changes
Update to use the old JSX transform to fix a regression.
Description of how you validated changes
Create a sample React app running on a React version prior to 16.14.0 and integrate ui-react library into the app
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.