Skip to content

style: cleaning up sr-only class in favor of VisuallyHidden and amplify-visually-hidden #1368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 21, 2022

Conversation

zchenwei
Copy link
Contributor

@zchenwei zchenwei commented Feb 18, 2022

Description of changes

Cleaning up sr-only class in favor of VisuallyHidden or amplify-visually-hidden class

Checklist

  • PR description included
  • yarn test passes
  • Tests are updated

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@changeset-bot
Copy link

changeset-bot bot commented Feb 18, 2022

🦋 Changeset detected

Latest commit: f7ad79f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@aws-amplify/ui-react Patch
@aws-amplify/ui Patch
@aws-amplify/ui-vue Patch
@aws-amplify/ui-angular Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@zchenwei zchenwei changed the title Chenwz cleanup visuallyhidden style: cleaning up sr-only class in favor of VisuallyHidden and amplify-visually-hidden Feb 18, 2022
@zchenwei zchenwei temporarily deployed to ci February 18, 2022 23:06 Inactive
@zchenwei zchenwei temporarily deployed to ci February 18, 2022 23:06 Inactive
@zchenwei zchenwei temporarily deployed to ci February 18, 2022 23:06 Inactive
@zchenwei zchenwei temporarily deployed to ci February 18, 2022 23:06 Inactive
@zchenwei zchenwei temporarily deployed to ci February 21, 2022 19:57 Inactive
@zchenwei zchenwei temporarily deployed to ci February 21, 2022 19:57 Inactive
@zchenwei zchenwei temporarily deployed to ci February 21, 2022 19:57 Inactive
@zchenwei zchenwei temporarily deployed to ci February 21, 2022 19:57 Inactive
Copy link
Contributor

@ErikCH ErikCH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zchenwei zchenwei enabled auto-merge (squash) February 21, 2022 22:16
@zchenwei zchenwei temporarily deployed to ci February 21, 2022 22:26 Inactive
@zchenwei zchenwei temporarily deployed to ci February 21, 2022 22:26 Inactive
@zchenwei zchenwei temporarily deployed to ci February 21, 2022 22:26 Inactive
@zchenwei zchenwei temporarily deployed to ci February 21, 2022 22:26 Inactive
@zchenwei zchenwei merged commit c57a023 into main Feb 21, 2022
@zchenwei zchenwei deleted the chenwz-cleanup-visuallyhidden branch February 21, 2022 22:37
@github-actions github-actions bot mentioned this pull request Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants