Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update itsybitsy_m0 and itsybitsy_m4 to HAL 0.17 #754

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

ianrrees
Copy link
Contributor

Summary

Quite a few small updates

I'm a bit unsettled about the HAL prelude. Using it winds up bringing in multiple traits which apparently require ugly disambiguation, it seems like this should be cleaner:

InterruptDrivenTimer::start(&mut timer, Hertz::MHz(4).into_duration());

Checklist

  • CHANGELOG.md for the BSP or HAL updated
  • All new or modified code is well documented, especially public items
  • No new warnings or clippy suggestions have been introduced - CI will deny clippy warnings by default! You may #[allow] certain lints where reasonable, but ideally justify those with a short comment.

@jbeaurivage
Copy link
Contributor

That should probably be a separate discussion, but I'm not a fan of the prelude in the first place. I'm happy to merge though if you think this is ready!

@jbeaurivage jbeaurivage merged commit 280b5e0 into atsamd-rs:master Aug 30, 2024
108 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants