Skip to content
This repository has been archived by the owner on Sep 21, 2018. It is now read-only.

Move webroot:wwwroot from project.json to Microsoft.AspNet.Hosting.json #257

Closed
Tratcher opened this issue Oct 23, 2015 · 9 comments
Closed
Assignees
Milestone

Comments

@Tratcher
Copy link
Member

https://github.com/aspnet/Templates/blob/dev/src/BaseTemplates/EmptyWeb/project.json#L2
Microsoft.AspNet.Hosting.json:

{
  "Hosting:WebRoot": "wwwroot"
}

Or

{
  "Hosting":
  {
     "WebRoot": "wwwroot"
  }
}

@DamianEdwards? I don't recommend promoting WebRoot to a top-level element.
aspnet/dnx#3035
aspnet/Hosting#411

@Tratcher
Copy link
Member Author

@davidfowl

@rustd
Copy link
Contributor

rustd commented Oct 23, 2015

@Tratcher rc1?

@Tratcher
Copy link
Member Author

Yes, rc1

@rustd rustd added this to the 1.0.0-rc1 milestone Oct 24, 2015
@phenning
Copy link
Contributor

This has some tooling impact as well.

@phenning
Copy link
Contributor

/cc @BillHiebert

@Tratcher
Copy link
Member Author

Feedback: remove the Microsoft.AspNet.Hosting.json file from the default templates. The runtime uses intelligent defaults and the file is only needed for customization.

@Tratcher Tratcher reopened this Oct 28, 2015
@Tratcher Tratcher removed the 3 - Done label Oct 28, 2015
@scottaddie
Copy link
Member

The gulpfile.js file included in the StarterWeb template will need to be adjusted accordingly. It currently pulls in the project.json file via require and then accesses its webroot property.

@rustd
Copy link
Contributor

rustd commented Oct 28, 2015

@Tratcher Let's remove the file if the runtime has defaults. The gulpfile will have to be updated to hard code wwwroot as a path.
@Tratcher are you reverting your change?

@Tratcher
Copy link
Member Author

I'll take care of the updates today

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants