Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v133 #1892

Merged
merged 22 commits into from
Jan 12, 2025
Merged

v133 #1892

merged 22 commits into from
Jan 12, 2025

Conversation

Thorin-Oakenpants
Copy link
Contributor

No description provided.

@Tiagoquix
Copy link
Contributor

Are we going to add browser.startup.windowsLaunchOnLogin.enabled as false for 1005?

@Thorin-Oakenpants
Copy link
Contributor Author

Are we going to add browser.startup.windowsLaunchOnLogin.enabled as false for 1005?

why? #1860

@Tiagoquix
Copy link
Contributor

Thanks for the clarification. I thought it was also used to enable the functionality itself.

@Thorin-Oakenpants Thorin-Oakenpants changed the title v130 v131 Oct 7, 2024
In FF133+ newwin and LB steps are now aligned - https://bugzilla.mozilla.org/show_bug.cgi?id=1556002 - so you won't open at one size and LB wants to be another

PS: privacy.window.max* sizes changed to 1400 x 900
@Thorin-Oakenpants Thorin-Oakenpants changed the title v131 v132 Nov 6, 2024
@mik0l
Copy link

mik0l commented Nov 7, 2024

Also remove webchannel.allowObject.urlWhitelist
see diffs

@Thorin-Oakenpants Thorin-Oakenpants changed the title v132 v133 Nov 29, 2024
@Tiagoquix
Copy link
Contributor

https://github.com/arkenfox/user.js/pull/1892/files/4f357398644f0ef3fe31083b9ae25259ee798247..7063ec250e9e7e593c6d3be04db9a132d2860a34 @Thorin-Oakenpants [NOTE}, please change to ], thanks!

@Tiagoquix
Copy link
Contributor

For 4510, does [SETTING] General>Language and Appearance>Fonts and Colors>Colors>Use system colors also control widget.non-native-theme.use-theme-accent? If not, I think we should clarify that.

@Tiagoquix
Copy link
Contributor

Tiagoquix commented Dec 24, 2024

Regarding the newly-added 4511, isn't it a previously-removed section/number? (Because 4510 and 4512 exist, while 4511 currently doesn't.)

If so, I believe it would be better to make it distinct? IDK; it seems Arkenfox User.js has this idea of never reusing previously-removed numbers.

@Thorin-Oakenpants
Copy link
Contributor Author

Thorin-Oakenpants commented Dec 24, 2024

it seems Arkenfox User.js has this idea of never reusing previously-removed numbers.

well, we have - done a few re-numberings of sections at times, and old numbers have either been repurposed or old ones since removed re-used. We just happen to have two 4511's at the same time (I want to keep the two system color prefs next to each other) - the ESR128 ESR115 deprecated section will get removed next PR (I could remove it now)

@Tiagoquix
Copy link
Contributor

fine by me to remove the ESR128 prefs in the next PR, no biggie

@Thorin-Oakenpants
Copy link
Contributor Author

actually, I meant the /* ESR115.x still uses all the following prefs sub-section

@Tiagoquix
Copy link
Contributor

also fine by me regarding ESR115 to be in the next PR
it's Christmas, let give people some time to update their user.js :)

Merry Chirstmas, by the way 🎄

@Thorin-Oakenpants Thorin-Oakenpants mentioned this pull request Jan 4, 2025
@Thorin-Oakenpants Thorin-Oakenpants merged commit b8f18a3 into master Jan 12, 2025
@Thorin-Oakenpants Thorin-Oakenpants deleted the Thorin-Oakenpants-patch-1 branch January 12, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants