Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a react-server entry point, remove rehackt #12438

Merged
merged 8 commits into from
Mar 14, 2025
Merged

Conversation

phryneas
Copy link
Member

This adds a React-Server entrypoint for @apollo/client/react and removes rehackt as a consequence, as we don't need that workaround anymore.

Also some new testing utils that we need to test exports with different conditions.

Copy link

changeset-bot bot commented Mar 14, 2025

🦋 Changeset detected

Latest commit: 76efc01

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svc-apollo-docs
Copy link

svc-apollo-docs commented Mar 14, 2025

⚠️ Docs preview not attached to branch

The preview was not built because the PR's base branch release-4.0 is not in the list of sources.

An Apollo team member can comment one of the following commands to dictate which branch to attach the preview to:

  • !docs set-base-branch version-2.6
  • !docs set-base-branch main

Build ID: 496d280f19c3b7ebab2295fa

Copy link

pkg-pr-new bot commented Mar 14, 2025

npm i https://pkg.pr.new/@apollo/client@12438

commit: 76efc01

Copy link

netlify bot commented Mar 14, 2025

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 76efc01
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/67d4539bc10af50007a13724
😎 Deploy Preview https://deploy-preview-12438--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Mar 14, 2025

size-limit report 📦

Path Size
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" (CJS) 41.78 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" (production) (CJS) 37.23 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" 32.31 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" (production) 27.29 KB (0%)
import { ApolloProvider } from "@apollo/client/react" 5.17 KB (-0.08% 🔽)
import { ApolloProvider } from "@apollo/client/react" (production) 960 B (-0.52% 🔽)
import { useQuery } from "@apollo/client/react" 7.26 KB (-0.06% 🔽)
import { useQuery } from "@apollo/client/react" (production) 3.06 KB (-0.13% 🔽)
import { useLazyQuery } from "@apollo/client/react" 6.39 KB (-0.19% 🔽)
import { useLazyQuery } from "@apollo/client/react" (production) 2.17 KB (-0.23% 🔽)
import { useMutation } from "@apollo/client/react" 6.47 KB (+0.14% 🔺)
import { useMutation } from "@apollo/client/react" (production) 2.22 KB (-0.44% 🔽)
import { useSubscription } from "@apollo/client/react" 6.83 KB (-0.23% 🔽)
import { useSubscription } from "@apollo/client/react" (production) 2.62 KB (-0.08% 🔽)
import { useSuspenseQuery } from "@apollo/client/react" 8.31 KB (-0.06% 🔽)
import { useSuspenseQuery } from "@apollo/client/react" (production) 4.12 KB (-0.19% 🔽)
import { useBackgroundQuery } from "@apollo/client/react" 8.15 KB (-0.14% 🔽)
import { useBackgroundQuery } from "@apollo/client/react" (production) 3.96 KB (-0.05% 🔽)
import { useLoadableQuery } from "@apollo/client/react" 8.21 KB (-0.06% 🔽)
import { useLoadableQuery } from "@apollo/client/react" (production) 4.02 KB (-0.05% 🔽)
import { useReadQuery } from "@apollo/client/react" 5.82 KB (+0.07% 🔺)
import { useReadQuery } from "@apollo/client/react" (production) 1.58 KB (0%)
import { useFragment } from "@apollo/client/react" 5.86 KB (-0.73% 🔽)
import { useFragment } from "@apollo/client/react" (production) 1.63 KB (-0.3% 🔽)

"@apollo/client": minor
---

Drop `rehackt` dependency.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@@ -13032,6 +13031,7 @@
},
"node_modules/rehackt": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious, where is this coming from now that its removed from the top-level package.json?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Answered my own question. It comes from @testing-library/react-render-stream

Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change!

@github-actions github-actions bot added the auto-cleanup 🤖 label Mar 14, 2025
@phryneas phryneas merged commit 5089516 into release-4.0 Mar 14, 2025
47 checks passed
@jerelmiller jerelmiller deleted the pr/handle-rsc branch March 17, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants