Fix networkStatus incorrectly reported as ready when using errorPolicy: 'all' with errors

[jerelmiller]

Fixes #12334

When calling observableQuery.getCurrentResult() when the errorPolicy was set to all, the networkStatus was incorrectly reporting the value as NetworkStatus.ready when there were errors returned in the result. This has now been corrected to return as NetworkStatus.error to match the value emitted from the observable.

This bug also affected useQuery and useLazyQuery since useQuery uses getCurrentResult under the hood.

[changeset-bot]

🦋 Changeset detected

Latest commit: 1576a09

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@apollo/client	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[svc-apollo-docs]

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: 38a4d1e6c82b9ebc2619afc3

[pkg-pr-new]

npm i https://pkg.pr.new/@apollo/client@12362

commit: 0a21f3b

[netlify]

✅ Deploy Preview for apollo-client-docs ready!

Name	Link
🔨 Latest commit	4e08f3b
🔍 Latest deploy log	https://app.netlify.com/sites/apollo-client-docs/deploys/67aa5f21b424f900087b1d49
😎 Deploy Preview	https://deploy-preview-12362--apollo-client-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

size-limit report 📦

Path	Size
dist/apollo-client.min.cjs	41.27 KB (+0.05% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs"	50.71 KB (+0.03% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production)	47.79 KB (+0.05% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js"	36.25 KB (+0.04% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production)	33.64 KB (+0.04% 🔺)
import { ApolloProvider } from "dist/react/index.js"	1.26 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production)	1.24 KB (0%)
import { useQuery } from "dist/react/index.js"	5.21 KB (0%)
import { useQuery } from "dist/react/index.js" (production)	4.29 KB (0%)
import { useLazyQuery } from "dist/react/index.js"	5.7 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production)	4.78 KB (0%)
import { useMutation } from "dist/react/index.js"	3.62 KB (0%)
import { useMutation } from "dist/react/index.js" (production)	2.84 KB (0%)
import { useSubscription } from "dist/react/index.js"	4.42 KB (0%)
import { useSubscription } from "dist/react/index.js" (production)	3.48 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js"	5.89 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production)	4.55 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js"	5.38 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production)	4.04 KB (0%)
import { useLoadableQuery } from "dist/react/index.js"	5.47 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production)	4.12 KB (0%)
import { useReadQuery } from "dist/react/index.js"	3.43 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production)	3.38 KB (0%)
import { useFragment } from "dist/react/index.js"	2.36 KB (0%)
import { useFragment } from "dist/react/index.js" (production)	2.31 KB (0%)

[netlify]

✅ Deploy Preview for apollo-client-docs ready!

Name	Link
🔨 Latest commit	1576a09
🔍 Latest deploy log	https://app.netlify.com/sites/apollo-client-docs/deploys/67cb26080e62f7000845789e
😎 Deploy Preview	https://deploy-preview-12362--apollo-client-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[jerelmiller]

This networkStatus might actually be legitimate since this is the loading state from the execute call. Looks like we just hold onto the error until the next request returns.

That said, its curious that we hold onto error here. In other cases (such as refetch) this error is reset until the next result comes back. This is different since we are calling execute again though which just re-evaluates the query against the fetch policy.

Should we be removing the error on this result in this case, or should we continue to handle this as-is? I think the loading state is the correct one here either way.

[phryneas]

Looks good to me :)