keep deferred inFlightLinkObservables until the response is finished

[phryneas]

An experiment. This might be required for query streaming with @defer and useSuspenseQuery.

[changeset-bot]

🦋 Changeset detected

Latest commit: b201bc0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@apollo/client	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[svc-apollo-docs]

⚠️ Docs preview not attached to branch

The preview was not built because the PR's base branch release-3.13 is not in the list of sources.

An Apollo team member can comment one of the following commands to dictate which branch to attach the preview to:

• !docs set-base-branch version-2.6
• !docs set-base-branch main

Build ID: cc19e4a82fbc673e4b124e13

[pkg-pr-new]

npm i https://pkg.pr.new/@apollo/client@12338

commit: b201bc0

[netlify]

✅ Deploy Preview for apollo-client-docs ready!

Name	Link
🔨 Latest commit	b201bc0
🔍 Latest deploy log	https://app.netlify.com/sites/apollo-client-docs/deploys/67a4a3f11cee2c0008cefa23
😎 Deploy Preview	https://deploy-preview-12338--apollo-client-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

size-limit report 📦

Path	Size
dist/apollo-client.min.cjs	41.24 KB (+0.07% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs"	50.68 KB (+0.06% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production)	47.75 KB (+0.06% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js"	36.24 KB (+0.09% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production)	33.63 KB (+0.08% 🔺)
import { ApolloProvider } from "dist/react/index.js"	1.26 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production)	1.24 KB (0%)
import { useQuery } from "dist/react/index.js"	5.21 KB (0%)
import { useQuery } from "dist/react/index.js" (production)	4.29 KB (0%)
import { useLazyQuery } from "dist/react/index.js"	5.7 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production)	4.78 KB (0%)
import { useMutation } from "dist/react/index.js"	3.62 KB (0%)
import { useMutation } from "dist/react/index.js" (production)	2.84 KB (0%)
import { useSubscription } from "dist/react/index.js"	4.42 KB (0%)
import { useSubscription } from "dist/react/index.js" (production)	3.48 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js"	5.88 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production)	4.54 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js"	5.37 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production)	4.03 KB (0%)
import { useLoadableQuery } from "dist/react/index.js"	5.45 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production)	4.11 KB (0%)
import { useReadQuery } from "dist/react/index.js"	3.42 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production)	3.36 KB (0%)
import { useFragment } from "dist/react/index.js"	2.36 KB (0%)
import { useFragment } from "dist/react/index.js" (production)	2.31 KB (0%)

[phryneas]

I have verified over in apollographql/apollo-client-nextjs#424 that this is exactly what this needs.

Gonna polish this PR, add a few tests and then we should get this into 3.13.

[phryneas]

Added a test, this should be ready for review.

[phryneas]

Note that this change right now applies to @defer etc., but not to subscriptions.
Changing that for subscriptions would be nice, but feels a bit more breaking, so I think we should probably do that in 4.0 - WDYT @jerelmiller ?

[jerelmiller]

That makes sense to me. I see no reason why two subscriptions kicked off with the same document/variables shouldn't be deduped, especially since it can be disabled per-subscription if need be. Mind making a tracking issue and putting it in the milestone so that we don't forget to update?

[phryneas]

#12348 👍

[jerelmiller]

Fantastic test addition that demonstrates all the things I was hoping to see. Thanks for getting this done!

[phryneas]

Fantastic test addition that demonstrates all the things I was hoping to see. Thanks for getting this done!

We're getting to a point where we have all the tools in place that writing these tests is actually fun :)