Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8909] Move nullcheck ahead #8910

Merged
merged 2 commits into from
Nov 16, 2024
Merged

[ISSUE #8909] Move nullcheck ahead #8910

merged 2 commits into from
Nov 16, 2024

Conversation

jjastan
Copy link
Contributor

@jjastan jjastan commented Nov 12, 2024

Which Issue(s) This PR Fixes

Fixes #8909

Brief Description

Move nullcheck ahead

How Did You Test This Change

No test.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 47.52%. Comparing base (321670a) to head (9d3ed5d).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...rocketmq/common/config/AbstractRocksDBStorage.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8910      +/-   ##
=============================================
- Coverage      47.54%   47.52%   -0.03%     
- Complexity     11729    11735       +6     
=============================================
  Files           1304     1304              
  Lines          91058    91058              
  Branches       11678    11677       -1     
=============================================
- Hits           43295    43274      -21     
- Misses         42415    42435      +20     
- Partials        5348     5349       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RongtongJin RongtongJin merged commit 4574647 into apache:develop Nov 16, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Nullcheck of value previously dereferenced
5 participants