Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8906] Handle string toUpperCase outside the loop #8907

Merged

Conversation

mawen12
Copy link
Contributor

@mawen12 mawen12 commented Nov 11, 2024

Which Issue(s) This PR Fixes

Fixes #8906

Brief Description

Handle string toUpperCase outside the loop

How Did You Test This Change?

No test.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 47.52%. Comparing base (7eb16ff) to head (6883fb5).

Files with missing lines Patch % Lines
...ocketmq/proxy/remoting/MultiProtocolTlsHelper.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8907      +/-   ##
=============================================
- Coverage      47.54%   47.52%   -0.03%     
- Complexity     11728    11732       +4     
=============================================
  Files           1304     1304              
  Lines          91056    91058       +2     
  Branches       11677    11677              
=============================================
- Hits           43297    43276      -21     
- Misses         42409    42441      +32     
+ Partials        5350     5341       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RongtongJin RongtongJin merged commit 2bbc852 into apache:develop Nov 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Handle string toUpperCase outside the loop
3 participants