Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8599] Throw exception when receiving GO_AWAY twice to close channel. #8862

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

qianye1001
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #8599

Brief Description

  1. Throw exception when receiving GO_AWAY twice to close channel.
  2. Throw exception when receiving GO_AWAY and nor enableReconnectForGoAway

How Did You Test This Change?

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 4.34783% with 22 lines in your changes missing coverage. Please review.

Project coverage is 47.35%. Comparing base (95b88ff) to head (50b2387).
Report is 12 commits behind head on develop.

Files with missing lines Patch % Lines
...e/rocketmq/remoting/netty/NettyRemotingClient.java 6.66% 14 Missing ⚠️
...pache/rocketmq/remoting/common/RemotingHelper.java 0.00% 7 Missing ⚠️
...rocketmq/remoting/netty/NettyRemotingAbstract.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8862      +/-   ##
=============================================
- Coverage      47.43%   47.35%   -0.09%     
+ Complexity     11660    11641      -19     
=============================================
  Files           1294     1294              
  Lines          90424    90412      -12     
  Branches       11627    11622       -5     
=============================================
- Hits           42894    42814      -80     
- Misses         42259    42313      +54     
- Partials        5271     5285      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lollipopjin lollipopjin merged commit 66ba456 into apache:develop Nov 14, 2024
11 checks passed
@qianye1001 qianye1001 deleted the issue-8599 branch November 14, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Optimize the graceful shutdown for the proxy remoting protocol server.
4 participants