-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #8829] feat: provide ConfigManagerV2 to make best uses of RocksDB #8856
Conversation
Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
broker/src/main/java/org/apache/rocketmq/broker/config/v2/SubscriptionGroupManagerV2.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @lizhanhui , we have been using version v1 in the production environment, and it's likely that some community users are doing the same. From a code perspective, a compatibility upgrade from v1 to v2 is not feasible. Given the need for compatibility upgrade, I think it's essential to add support for persisting lmq consumer offsets in version v1.
Let's do this in the next pull request. This pull request has been kind of too large. |
LGTM |
Which Issue(s) This PR Fixes
To #8829
Brief Description
How Did You Test This Change?