Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8804] clean offset when remove group offset #8805

Merged

Conversation

leizhiyuan
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #8804

Brief Description

implement the clean offset,then we invoke deleteSubscriptionGroup ,we can clean

How Did You Test This Change?

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 47.41%. Comparing base (95b1c51) to head (d9c44ff).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...cketmq/broker/offset/LmqConsumerOffsetManager.java 0.00% 15 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8805      +/-   ##
=============================================
- Coverage      47.47%   47.41%   -0.06%     
+ Complexity     11591    11576      -15     
=============================================
  Files           1283     1283              
  Lines          89888    89903      +15     
  Branches       11568    11571       +3     
=============================================
- Hits           42670    42629      -41     
- Misses         41981    42027      +46     
- Partials        5237     5247      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RongtongJin
Copy link
Contributor

LGTM~

@RongtongJin RongtongJin merged commit e75554d into apache:develop Oct 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] we do not clean lmq offset in lmqOffsetTable
3 participants