Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8725]clean DefaultMQPushConsumer after start fail #8726

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

yuz10
Copy link
Member

@yuz10 yuz10 commented Sep 21, 2024

Which Issue(s) This PR Fixes

Fixes #8725

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2024

Codecov Report

Attention: Patch coverage is 30.76923% with 9 lines in your changes missing coverage. Please review.

Project coverage is 47.50%. Comparing base (945e7ea) to head (01cb8c7).
Report is 49 commits behind head on develop.

Files with missing lines Patch % Lines
...lient/impl/consumer/DefaultMQPushConsumerImpl.java 25.00% 5 Missing and 1 partial ⚠️
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 40.00% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8726      +/-   ##
=============================================
- Coverage      47.53%   47.50%   -0.03%     
+ Complexity     11551    11548       -3     
=============================================
  Files           1279     1279              
  Lines          89562    89570       +8     
  Branches       11516    11516              
=============================================
- Hits           42569    42554      -15     
- Misses         41773    41792      +19     
- Partials        5220     5224       +4     
Flag Coverage Δ
47.50% <30.76%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuz10 yuz10 merged commit 5600684 into apache:develop Oct 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] DefaultMQPushConsumer don't clean after start fail
3 participants