Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8402] Fix init retry topic offset incorrect when EscapeBridge enabled #8404

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

imzs
Copy link
Contributor

@imzs imzs commented Jul 19, 2024

…ssages incorrectly when EscapeBridge enabled

- fix typo
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 45.12%. Comparing base (d9d53d5) to head (0f060a1).

Files Patch % Lines
...rocketmq/broker/processor/PopMessageProcessor.java 75.00% 0 Missing and 1 partial ⚠️
...he/rocketmq/broker/processor/PopReviveService.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #8404   +/-   ##
==========================================
  Coverage      45.12%   45.12%           
- Complexity     10931    10941   +10     
==========================================
  Files           1274     1274           
  Lines          88970    88970           
  Branches       11434    11434           
==========================================
+ Hits           40144    40146    +2     
- Misses         43826    43827    +1     
+ Partials        5000     4997    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imzs imzs changed the title fix #8402 pop of retryTopic from maxOffset will skip a few messages incorrectly when EscapeBridge enabled [ISSUE #8402] pop of retryTopic from maxOffset will skip a few messages incorrectly when EscapeBridge enabled Jul 19, 2024
@lizhimins lizhimins changed the title [ISSUE #8402] pop of retryTopic from maxOffset will skip a few messages incorrectly when EscapeBridge enabled [ISSUE #8402] Fix init retry topic offset incorrect when EscapeBridge enabled Jul 23, 2024
@lizhimins lizhimins merged commit 8341c13 into apache:develop Jul 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants