Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8261]Avoid unnecessary waiting when a response is successfully returned #8272

Merged
merged 5 commits into from
Jul 29, 2024

Conversation

3424672656
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #8261

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 42.80%. Comparing base (3ecc73b) to head (4d29bb1).

Files Patch % Lines
...mq/client/impl/producer/DefaultMQProducerImpl.java 0.00% 3 Missing ⚠️
...ocketmq/client/producer/RequestResponseFuture.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8272      +/-   ##
=============================================
- Coverage      42.88%   42.80%   -0.08%     
+ Complexity     10396    10380      -16     
=============================================
  Files           1274     1274              
  Lines          88956    88961       +5     
  Branches       11438    11438              
=============================================
- Hits           38151    38083      -68     
- Misses         46102    46168      +66     
- Partials        4703     4710       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@GenerousMan GenerousMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GenerousMan
Copy link
Contributor

LGTM, but would it be better to add countDown in this piece of code?

public void setSendRequestOk(boolean sendRequestOk) {
    this.sendRequestOk = sendRequestOk;
}

@3424672656
Copy link
Contributor Author

countDownLGTM,但是添加代码会更好吗?

public void setSendRequestOk(boolean sendRequestOk) {
    this.sendRequestOk = sendRequestOk;
}

But exception callbacks are also used
image

@RongtongJin RongtongJin merged commit 2d44ec8 into apache:develop Jul 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Avoid unnecessary waiting when a response is successfully returned
4 participants