Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8269] Support pop consumption filter in long polling service #8271

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

lizhimins
Copy link
Member

Which Issue(s) This PR Fixes

Fixes #8269

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 20.40816% with 39 lines in your changes missing coverage. Please review.

Project coverage is 42.84%. Comparing base (155bcbf) to head (254d3f4).

Files Patch % Lines
...etmq/broker/longpolling/PopLongPollingService.java 6.25% 15 Missing ⚠️
...rocketmq/broker/processor/PopMessageProcessor.java 42.85% 7 Missing and 1 partial ⚠️
...ker/longpolling/NotifyMessageArrivingListener.java 0.00% 6 Missing ⚠️
...rocketmq/broker/processor/AckMessageProcessor.java 0.00% 5 Missing ⚠️
...cketmq/broker/processor/NotificationProcessor.java 0.00% 3 Missing ⚠️
...apache/rocketmq/broker/longpolling/PopRequest.java 60.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8271      +/-   ##
=============================================
- Coverage      42.88%   42.84%   -0.04%     
+ Complexity     10375    10371       -4     
=============================================
  Files           1271     1271              
  Lines          88793    88819      +26     
  Branches       11414    11417       +3     
=============================================
- Hits           38075    38058      -17     
- Misses         46007    46053      +46     
+ Partials        4711     4708       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@drpmma drpmma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lizhimins lizhimins merged commit d1974c5 into apache:develop Jun 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Support pop consumption filter in long polling service
3 participants