[ISSUE #8058] Support for upgrading metadata in json to rocksdb (#8045) #8116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RongtongJin
reviewed
May 13, 2024
没问题 |
lizhimins
previously approved these changes
May 22, 2024
RongtongJin
previously approved these changes
May 22, 2024
LetLetMe
changed the title
lollipopjin
reviewed
May 24, 2024
| this.configRocksDBStorage = new ConfigRocksDBStorage(filePath); | ||
| return this.configRocksDBStorage.start(); | ||
| } | ||
| public final boolean loadDataVersion() { |
There was a problem hiding this comment.
Why use public final for method here?
| kvDataVersion = StringUtils.isNotBlank(currDataVersionString) ? JSON.parseObject(currDataVersionString, DataVersion.class) : new DataVersion(); | ||
| return true; | ||
| } catch (Exception e) { | ||
| throw new RuntimeException(e); |
There was a problem hiding this comment.
How about print some information for the exception here?
| return true; | ||
| } | ||
|
|
||
| public boolean loadSubscriptionGroupAndForbidden() { |
There was a problem hiding this comment.
If you want to do as a pipeline case here , use if-else may be a more readable way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #8058
Brief Description
How Did You Test This Change?