Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7904] use string builder to concat string #7905

Merged

Conversation

ChineseTony
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #7904

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 42.95%. Comparing base (db4c7da) to head (d90cd44).
Report is 168 commits behind head on develop.

Files Patch % Lines
.../rocketmq/common/namesrv/DefaultTopAddressing.java 0.00% 7 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7905      +/-   ##
=============================================
+ Coverage      42.92%   42.95%   +0.02%     
- Complexity      9909     9920      +11     
=============================================
  Files           1190     1190              
  Lines          86042    86042              
  Branches       11081    11081              
=============================================
+ Hits           36935    36959      +24     
+ Misses         44531    44521      -10     
+ Partials        4576     4562      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RongtongJin RongtongJin merged commit ab9a401 into apache:develop Mar 14, 2024
9 of 10 checks passed
@ChineseTony ChineseTony deleted the using_string_builder_conact_string branch March 14, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]Using StringBuilder to concat string
3 participants