Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7676] use clientDecode for consuming message directly #7677

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

cserwen
Copy link
Member

@cserwen cserwen commented Dec 19, 2023

Which Issue(s) This PR Fixes

Fixes #7676

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a376fbc) 43.19% compared to head (680d741) 43.12%.
Report is 7 commits behind head on develop.

Files Patch % Lines
.../rocketmq/client/impl/ClientRemotingProcessor.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7677      +/-   ##
=============================================
- Coverage      43.19%   43.12%   -0.07%     
+ Complexity      9812     9796      -16     
=============================================
  Files           1165     1165              
  Lines          84461    84482      +21     
  Branches       10964    10968       +4     
=============================================
- Hits           36482    36434      -48     
- Misses         43454    43522      +68     
- Partials        4525     4526       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RongtongJin RongtongJin changed the title [#7676] use clientDecode for consuming message directly [ISSUE #7676] use clientDecode for consuming message directly Dec 19, 2023
@RongtongJin
Copy link
Contributor

LGTM~

Copy link
Contributor

@joeCarf joeCarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cserwen cserwen merged commit c101216 into apache:develop Dec 20, 2023
@cserwen cserwen deleted the fix_consumeId_for_directly branch June 19, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Use clientDecode for consuming message directly
4 participants