Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7585] Always return duplicate buffer when filter message and fix log format #7654

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

lizhimins
Copy link
Member

@lizhimins lizhimins commented Dec 13, 2023

…format

Which Issue(s) This PR Fixes

Fixes #7585

When pull messages from the cache of tiered storage, always return a copy of the byte buffer instead of the buffer itself.

从分级存储的缓存获取消息时,将返回消息 buffer 的副本而不是 buffer 本身。

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (a376fbc) 43.19% compared to head (0a9bba4) 43.14%.

Files Patch % Lines
...cketmq/tieredstore/common/GetMessageResultExt.java 0.00% 2 Missing ⚠️
...cketmq/tieredstore/provider/TieredFileSegment.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7654      +/-   ##
=============================================
- Coverage      43.19%   43.14%   -0.06%     
+ Complexity      9812     9800      -12     
=============================================
  Files           1165     1165              
  Lines          84461    84461              
  Branches       10964    10964              
=============================================
- Hits           36482    36438      -44     
- Misses         43454    43501      +47     
+ Partials        4525     4522       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lizhimins lizhimins changed the title [ISSUE #7585] Always return duplicate buffer when filter and fix log format [ISSUE #7585] Always return duplicate buffer when filter message and fix log format Dec 13, 2023
@lizhimins lizhimins merged commit 50a92a2 into apache:develop Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Support message filtering in rocketmq tiered storage
3 participants