-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #7199] grpcClientChannel header add null judgement #7238
[ISSUE #7199] grpcClientChannel header add null judgement #7238
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #7238 +/- ##
=============================================
- Coverage 42.97% 42.94% -0.03%
+ Complexity 9670 9661 -9
=============================================
Files 1161 1161
Lines 83926 83926
Branches 10898 10898
=============================================
- Hits 36069 36045 -24
- Misses 43380 43403 +23
- Partials 4477 4478 +1
... and 32 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
proxy/src/main/java/org/apache/rocketmq/proxy/grpc/v2/channel/GrpcClientChannel.java
Show resolved
Hide resolved
@Oliverwqcwrw Can you look at this pr? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although I don't think the header should be null in theory, it is necessary for the robustness of the code to add this null judgment.
@RongtongJin Can you help merge this pr |
@Oliverwqcwrw Can you help merge this pr |
…bugfix_grpcClient_null
@RongtongJin Can you help merge this pr |
This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR. |
@Oliverwqcwrw Can you look at this pr? |
Thanks for your contribution |
#7199