Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7199] grpcClientChannel header add null judgement #7238

Merged

Conversation

weihubeats
Copy link
Member

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2023

Codecov Report

Merging #7238 (dae83ec) into develop (82b2f8e) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #7238      +/-   ##
=============================================
- Coverage      42.97%   42.94%   -0.03%     
+ Complexity      9670     9661       -9     
=============================================
  Files           1161     1161              
  Lines          83926    83926              
  Branches       10898    10898              
=============================================
- Hits           36069    36045      -24     
- Misses         43380    43403      +23     
- Partials        4477     4478       +1     
Files Coverage Δ
...ketmq/proxy/grpc/v2/channel/GrpcClientChannel.java 53.70% <0.00%> (ø)

... and 32 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@weihubeats
Copy link
Member Author

@Oliverwqcwrw Can you look at this pr?

Copy link
Member

@Oliverwqcwrw Oliverwqcwrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I don't think the header should be null in theory, it is necessary for the robustness of the code to add this null judgment.

@weihubeats
Copy link
Member Author

@RongtongJin Can you help merge this pr

@weihubeats
Copy link
Member Author

@Oliverwqcwrw Can you help merge this pr

@weihubeats
Copy link
Member Author

@RongtongJin Can you help merge this pr

Copy link

This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.

@github-actions github-actions bot added the stale label Nov 28, 2024
@weihubeats
Copy link
Member Author

@Oliverwqcwrw Can you look at this pr?

@Oliverwqcwrw Oliverwqcwrw merged commit d2c436b into apache:develop Nov 28, 2024
@Oliverwqcwrw
Copy link
Member

@Oliverwqcwrw Can you look at this pr?

Thanks for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants