Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7201] Remove the DefaultMessageStore.class dependency in TransientStorePool #7202

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

guyinyou
Copy link
Contributor

@guyinyou guyinyou commented Aug 17, 2023

….class

Which Issue(s) This PR Fixes

Fixes #7201

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Merging #7202 (362c9d1) into develop (5a3de92) will increase coverage by 0.00%.
Report is 1 commits behind head on develop.
The diff coverage is 24.19%.

@@            Coverage Diff             @@
##             develop    #7202   +/-   ##
==========================================
  Coverage      42.47%   42.48%           
- Complexity      9352     9357    +5     
==========================================
  Files           1149     1149           
  Lines          82042    82059   +17     
  Branches       10699    10699           
==========================================
+ Hits           34847    34862   +15     
+ Misses         42837    42829    -8     
- Partials        4358     4368   +10     
Files Changed Coverage Δ
.../rocketmq/broker/metrics/BrokerMetricsManager.java 11.27% <0.00%> (-0.62%) ⬇️
...che/rocketmq/broker/metrics/PopMetricsManager.java 28.97% <0.00%> (+0.26%) ⬆️
...q/controller/metrics/ControllerMetricsManager.java 19.37% <0.00%> (ø)
...ketmq/remoting/metrics/RemotingMetricsManager.java 11.11% <0.00%> (+0.30%) ⬆️
...ache/rocketmq/store/AllocateMappedFileService.java 39.28% <0.00%> (ø)
...n/java/org/apache/rocketmq/store/MessageStore.java 0.00% <ø> (ø)
...etmq/store/metrics/DefaultStoreMetricsManager.java 18.01% <ø> (ø)
...ketmq/store/plugin/AbstractPluginMessageStore.java 0.00% <ø> (ø)
.../java/org/apache/rocketmq/common/BrokerConfig.java 27.23% <25.00%> (-0.02%) ⬇️
...org/apache/rocketmq/store/DefaultMessageStore.java 46.75% <25.00%> (-0.19%) ⬇️
... and 3 more

... and 26 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@RongtongJin RongtongJin merged commit 3df1b92 into apache:develop Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Remove the DefaultMessageStore.class dependency in TransientStorePool.class
3 participants