Update mqbroker to use runbroker.sh instead of runserver.sh when enabling --enable-proxy #7150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…--enable-proxy Update mqbroker to use runbroker.sh instead of runserver.sh when enabling `--enable-proxy` this allow JVM `heap` and `gc` configuration using broker's settings instead of other common serverices'(proxy,namenode, etc). our main purpose, like the filename `mqbroker` suggest, is to start broker (which embeds a proxy), so use broker's config is reasonable chinese version mqbroker的--enable-proxy选项是启动内嵌了proxy的broker，而不是内嵌broker的proxy，而且broker的工作量和重要程度大于proxy，所以使用broker的gc和heap配置更合适
iamgd67
changed the title
xdkxlk
approved these changes
Aug 10, 2023
|
@xdkxlk |
iamgd67
force-pushed
the
iamgd67-patch-1
branch
from
13c6d34 to
c2ba8fa
Compare
|
@xdkxlk cleaned commit history, can you trigger the workflows? |
OK |
Codecov Report
@@ Coverage Diff @@
## develop #7150 +/- ##
=============================================
+ Coverage 42.12% 42.24% +0.12%
- Complexity 9260 9413 +153
=============================================
Files 1149 1149
Lines 82033 83176 +1143
Branches 10699 10858 +159
=============================================
+ Hits 34554 35137 +583
- Misses 43129 43667 +538
- Partials 4350 4372 +22 see 29 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@xdkxlk are we ready to merge this or waiting for more reviews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
no issue
Brief Description
Update mqbroker to use runbroker.sh instead of runserver.sh when enabling
--enable-proxythis allow JVMheapandgcconfiguration using broker's settings instead of other common serverices'(proxy,namenode, etc). our main purpose, like the filenamemqbrokersuggest, is to start broker (which embeds a proxy), so use broker's config is reasonablechinese version
mqbroker的--enable-proxy选项是启动内嵌了proxy的broker，而不是内嵌broker的proxy，而且broker的工作量和重要程度大于proxy，所以使用broker的gc和heap配置更合适
How Did You Test This Change?
after the change, started broker using configs in runbroker.sh and work well