Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] schedule CQ offset invalid. offset=77, cqMinOffset=0, cqMaxOffset=74, queueId=1 #7084

Merged
merged 7 commits into from
Aug 1, 2023
Merged

[Bug] schedule CQ offset invalid. offset=77, cqMinOffset=0, cqMaxOffset=74, queueId=1 #7084

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f79cbe4
Adding null does not update
weihubeats Jun 8, 2023
0d4e93e
Merge remote-tracking branch 'apache_master/develop' into weihubeats/…
weihubeats Jul 26, 2023
980b75a
delete slave put correctDelayOffset
weihubeats Jul 26, 2023
0e6ba8f
Remove duplicate delayOffset file loading
weihubeats Jul 27, 2023
0c85891
add loadWhenSyncDelayOffset
weihubeats Jul 28, 2023
2a51d94
add method
weihubeats Jul 29, 2023
4b3b105
add method
weihubeats Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion broker/src/main/java/org/apache/rocketmq/broker/schedule/ScheduleMessageService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,6 @@ public boolean correctDelayOffset() {
}
if (correctDelayOffset != currentDelayOffset) {
log.error("correct delay offset [ delayLevel {} ] from {} to {}", delayLevel, currentDelayOffset, correctDelayOffset);
offsetTable.put(delayLevel, correctDelayOffset);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is not put in the table, the correction will have no effect.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So there should be no reloading of the delayOffset.json file here, right?

}
}
} catch (Exception e) {
Expand Down