Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passing the renew event type to create the correct context #7045

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

xdkxlk
Copy link
Contributor

@xdkxlk xdkxlk commented Jul 19, 2023

Which Issue(s) This PR Fixes

Fixes #7044

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2023

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 42.66%. Comparing base (440be1e) to head (91fba44).
Report is 447 commits behind head on develop.

Files with missing lines Patch % Lines
...a/org/apache/rocketmq/proxy/common/RenewEvent.java 85.71% 1 Missing ⚠️
...cketmq/proxy/processor/ReceiptHandleProcessor.java 0.00% 1 Missing ⚠️
...y/service/receipt/DefaultReceiptHandleManager.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7045      +/-   ##
=============================================
+ Coverage      42.62%   42.66%   +0.04%     
- Complexity      9230     9244      +14     
=============================================
  Files           1136     1136              
  Lines          80652    80668      +16     
  Branches       10542    10545       +3     
=============================================
+ Hits           34375    34420      +45     
+ Misses         41981    41954      -27     
+ Partials        4296     4294       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@drpmma drpmma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xdkxlk xdkxlk merged commit e0f5295 into apache:develop Jul 19, 2023
@xdkxlk xdkxlk deleted the develop-7044 branch July 19, 2023 07:55
Copy link
Member

@lizhimins lizhimins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Passing the renew event type to create the correct context
4 participants