Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Compilation error due to outdated method parameter in TimerMessageStoreTest #9042

Closed
3 tasks done
chi3316 opened this issue Dec 9, 2024 · 0 comments · Fixed by #9041
Closed
3 tasks done

[Bug] Compilation error due to outdated method parameter in TimerMessageStoreTest #9042

chi3316 opened this issue Dec 9, 2024 · 0 comments · Fixed by #9041

Comments

@chi3316
Copy link
Contributor

chi3316 commented Dec 9, 2024

Before Creating the Bug Report

  • I found a bug, not just asking a question, which should be created in GitHub Discussions.

  • I have searched the GitHub Issues and GitHub Discussions of this repository and believe that this is not a duplicate.

  • I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.

Runtime platform environment

OS: Ubuntu 22.04

RocketMQ version

Git commit id : bfb3d17

JDK Version

No response

Describe the Bug

After modifying the createTimerMessageStore method's parameters in TimerMessageStoreTest, a later PR did not rebase to the latest code and was still using the old method signature. This resulted in compilation errors, which caused CI to fail.
image

Steps to Reproduce

  1. Modify the createTimerMessageStore method parameters in TimerMessageStoreTest.
  2. Merge a PR without rebasing to the latest code, causing method calls to use the outdated parameters.
  3. Attempt to build the project, which will fail due to the mismatched parameters.

What Did You Expect to See?

The CI should pass without any compilation errors.

What Did You See Instead?

Compilation errors in the CI pipeline due to outdated method parameter usage in the PR.

Additional Context

No response

RongtongJin pushed a commit that referenced this issue Dec 10, 2024
…9041)

* Update createTimerMessageStore call with new parameter

* Reduce unit test execution time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant