[Bug] networkutil code logical errors #8289
Comments
zekai-li
added a commit
to zekai-li/rocketmq
that referenced
this issue
Jun 12, 2024
Fix the following three as
1，TraceBean： private static final String LOCAL_ADDRESS = UtilAll.ipToIPv4Str(UtilAll.getIP()); getIP mayby ipv6
2，NetworkUtil：if (ip.startsWith("127.0") || ip.startsWith("192.168") || ip.startsWith("0."))；Check whether Intranet errors exist
zekai-li
added a commit
to zekai-li/rocketmq
that referenced
this issue
Jun 13, 2024
Fix the following three as
1，TraceBean： private static final String LOCAL_ADDRESS = UtilAll.ipToIPv4Str(UtilAll.getIP()); getIP mayby ipv6
2，NetworkUtil：if (ip.startsWith("127.0") || ip.startsWith("192.168") || ip.startsWith("0."))；Check whether Intranet errors exist
francisoliverlee
pushed a commit
that referenced
this issue
Aug 15, 2024
* [ISSUE #8289] Fixed network bugs and merged networkutil code Fix the following three as 1，TraceBean： private static final String LOCAL_ADDRESS = UtilAll.ipToIPv4Str(UtilAll.getIP()); getIP mayby ipv6 2，NetworkUtil：if (ip.startsWith("127.0") || ip.startsWith("192.168") || ip.startsWith("0."))；Check whether Intranet errors exist * [ISSUE #8289] Fixed network bugs and merged networkutil code Fix the following three as 1，TraceBean： private static final String LOCAL_ADDRESS = UtilAll.ipToIPv4Str(UtilAll.getIP()); getIP mayby ipv6 2，NetworkUtil：if (ip.startsWith("127.0") || ip.startsWith("192.168") || ip.startsWith("0."))；Check whether Intranet errors exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Before Creating the Bug Report
I found a bug, not just asking a question, which should be created in GitHub Discussions.
I have searched the GitHub Issues and GitHub Discussions of this repository and believe that this is not a duplicate.
I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.
Runtime platform environment
linux
RocketMQ version
develop
JDK Version
jdk8
Describe the Bug
1，TraceBean： private static final String LOCAL_ADDRESS = UtilAll.ipToIPv4Str(UtilAll.getIP()); getIP mayby ipv6
2，NetworkUtil：if (ip.startsWith("127.0") || ip.startsWith("192.168") || ip.startsWith("0."))；Check whether Intranet errors exist
3，0.0.0.0 到 0.255.255.255 通常不用于生产环境，因为它们可能与某些保留的地址或特殊用途的地址重叠。
Steps to Reproduce
Read code logic
What Did You Expect to See?
Read code logic
What Did You See Instead?
No response
Additional Context
No response
The text was updated successfully, but these errors were encountered: