Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Add @Override annotation for handleDiskFlush method #8235

Closed
1 task done
mxsm opened this issue Jun 1, 2024 · 0 comments · Fixed by #8236
Closed
1 task done

[Enhancement] Add @Override annotation for handleDiskFlush method #8235

mxsm opened this issue Jun 1, 2024 · 0 comments · Fixed by #8236
Labels
type/enhancement

Comments

@mxsm
Copy link
Member

mxsm commented Jun 1, 2024

Before Creating the Enhancement Request

  • I have confirmed that this should be classified as an enhancement rather than a bug/feature.

Summary

image

Motivation

The handleDiskFlush method does not have the @Override annotation.

Describe the Solution You'd Like

Add @OverRide annotation for method

Describe Alternatives You've Considered

Add @OverRide annotation for method

Additional Context

No response
@mxsm mxsm changed the title [Enhancement] Add @Override annotation for method [Enhancement] Add @Override annotation for handleDiskFlush method Jun 1, 2024
mxsm added a commit to mxsm/rocketmq that referenced this issue Jun 1, 2024
@mxsm
[ISSUE apache#8235]Add @OverRide annotation for handleDiskFlush method
950e58b
@mxsm mxsm mentioned this issue Jun 1, 2024
Merged
RongtongJin pushed a commit that referenced this issue Jun 1, 2024
@mxsm
[ISSUE #8235]Add @OverRide annotation for handleDiskFlush method (#8236)
144b22b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #8235]Add @Override annotation for handleDiskFlush method mxsm/rocketmq
1 participant
@mxsm