Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Modify variable names to enhance readability #8182

Closed
1 task done
Stephanie0002 opened this issue May 23, 2024 · 0 comments · Fixed by #8183
Closed
1 task done

[Enhancement] Modify variable names to enhance readability #8182

Stephanie0002 opened this issue May 23, 2024 · 0 comments · Fixed by #8183

Comments

@Stephanie0002
Copy link
Contributor

Before Creating the Enhancement Request

  • I have confirmed that this should be classified as an enhancement rather than a bug/feature.

Summary

Modify the variable names subscription in file ./example/src/main/java/org/apache/rocketmq/example/operation/Consumer.java to enhance readability

Motivation

Subscription relationships are generally defined using subscription groups. Create different subscription groups, and different consumers determine their subscription relationships to topics by belonging to different subscription groups. Therefore, the variable name ‘group’ in this file not only contains the meaning of the group, but also the meaning of the subscription relationship. On the other hand, the file defines the filtering rule expression strings of different consumers in subscription relationships as variable ‘subscription’, but the meaning of this variable name mainly lies in the filtering rule expression. The ambiguity in the definitions of these two variable names can easily lead people to believe that variable ‘group’ only expresses consumer groups, The variable ‘subscription’ represents a subscription relationship.

Describe the Solution You'd Like

I plan to change the variable name 'group' to 'subGroup' and change the variable name 'subscription' to 'subExpression'

Describe Alternatives You've Considered

change the variable name 'group' to 'subGroup' and change the variable name 'subscription' to 'subFilterExpression'

Additional Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant