-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Pop retry topic v2 #7543
Closed
1 task done
Labels
Comments
drpmma
added a commit
that referenced
this issue
Nov 23, 2023
lizhimins
pushed a commit
to lizhimins/rocketmq
that referenced
this issue
Nov 27, 2023
* Implement pop retry topic v2 * Use pop retry topic v2 to notify the origin topic * add parse group * retry topic v2 compatibility * calculate consumer lag * delete retry topic
Use "+" as the separator. |
This was referenced Dec 13, 2023
drpmma
added a commit
that referenced
this issue
Dec 15, 2023
drpmma
added a commit
that referenced
this issue
Dec 15, 2023
drpmma
added a commit
that referenced
this issue
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Before Creating the Enhancement Request
Summary
目前在pop机制中使用的retry topic的格式是形如 "%RETRY%group_topic",其中分隔符"_"是一个合法字符,可以被使用在topic或者group中,因此会导致两个问题。
因此本方案提出了pop retry topic v2,以"+"为分割符,即形如"%RETRY%group+topic",其中"+"为topic和group无法使用的字符,因此解决了上述两个问题,同时"+"也隐式的表达了订阅的含义。
Currently, in the pop mechanism, the format used for the retry topic is as the form of "%RETRY%group_topic". The underscore character "_" serves as a valid separator, which can be used within both the topic and group. Consequently, this situation leads to two issues:
Therefore, this proposal suggests the implementation of pop retry topic v2, employing the "+" as the separator. The new format would appear as "%RETRY%group+topic". Since "+" is not a permissible character in either topics or groups, it effectively resolves the aforementioned issues. Furthermore, the use of "+" implicitly expresses the subscription meaning.
Motivation
Fix the issue of original pop retry topic.
Describe the Solution You'd Like
Retry topic v2 as the format of "%RETRY%group+topic" where "+" is the separator.
Describe Alternatives You've Considered
No
Additional Context
No response
The text was updated successfully, but these errors were encountered: