Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] class Topiclist use CopyOnWriteArraySet will cause timeout #7534

Closed
3 tasks done
keranbingaa opened this issue Nov 3, 2023 · 0 comments · Fixed by #7583
Closed
3 tasks done

[Bug] class Topiclist use CopyOnWriteArraySet will cause timeout #7534

keranbingaa opened this issue Nov 3, 2023 · 0 comments · Fixed by #7583

Comments

@keranbingaa
Copy link
Contributor

Before Creating the Bug Report

  • I found a bug, not just asking a question, which should be created in GitHub Discussions.

  • I have searched the GitHub Issues and GitHub Discussions of this repository and believe that this is not a duplicate.

  • I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.

Runtime platform environment

centos

RocketMQ version

release 5.1.3

JDK Version

jdk8

Describe the Bug

when topic list in namesrv is huge(eg:50000), the interface getAllTopicList in routeinfomanager will cost a lot time,which may be timeout.

Steps to Reproduce

use tools to call this interface, and calculate the time

What Did You Expect to See?

topiclist on namesrv

What Did You See Instead?

timeout

Additional Context

No response
keranbingaa added a commit to keranbingaa/rocketmq that referenced this issue Nov 15, 2023
@keranbingaa
fix ISSUE apache#7534
fa17940
@keranbingaa keranbingaa mentioned this issue Nov 15, 2023
Closed
keranbingaa added a commit to keranbingaa/rocketmq that referenced this issue Nov 24, 2023
@keranbingaa
add unit test for ISSUE apache#7534
298e02e
keranbingaa added a commit to keranbingaa/rocketmq that referenced this issue Nov 27, 2023
@keranbingaa
fix ISSUE apache#7534
e9a52ac
@keranbingaa keranbingaa mentioned this issue Nov 27, 2023
Merged
RongtongJin added a commit that referenced this issue Dec 1, 2023
@keranbingaa @RongtongJin
[ISSUE #7534] Use high performance concurrent set to replace copyonwr…
65faea2 
…iteset (#7583)

* fix ISSUE #7534

* reformat code

* Remove the useless unit test

---------

Co-authored-by: RongtongJin <jinrongtong16@mails.ucas.ac.cn>
@Wuyunfan-BUPT Wuyunfan-BUPT mentioned this issue Dec 4, 2023
Merged
Wuyunfan-BUPT added a commit to Wuyunfan-BUPT/rocketmq that referenced this issue Dec 4, 2023
@Wuyunfan-BUPT
Merge pull request #14 from apache/develop
3a96d9c 
[ISSUE apache#7534] Use high performance concurrent set to replace copyonwr…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@keranbingaa