Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Introduce a new event NettyEventType.ACTIVE for ChannelEventListener #7493

Closed
1 task done
drpmma opened this issue Oct 23, 2023 · 0 comments · Fixed by #7494
Closed
1 task done

[Enhancement] Introduce a new event NettyEventType.ACTIVE for ChannelEventListener #7493

drpmma opened this issue Oct 23, 2023 · 0 comments · Fixed by #7494
Labels
type/enhancement

Comments

@drpmma
Copy link
Contributor

drpmma commented Oct 23, 2023 •
edited
Loading

Before Creating the Enhancement Request

  • I have confirmed that this should be classified as an enhancement rather than a bug/feature.

Summary

Introduce a new event NettyEventType.ACTIVE, implement channelActive for NettyRemotingClient#NettyConnectManageHandler
and add onChannelActive for ChannelEventListener.

Motivation

The ChannelEventListener in NettyRemotingClient lacks a response to channelActive. In contrast, the ChannelEventListener in NettyRemotingServer handles channelActive, but generates NettyEventType.CONNECT events.

Since the ChannelEventListener in NettyRemotingClient already handles channelConnect using NettyEventType.CONNECT, we should introduce a new event, NettyEventType.ACTIVE, to handle channelActive in NettyRemotingClient.

This plan focuses solely on the ACTIVE event for NettyRemotingClient and does not address the semantics of CONNECT and ACTIVE in NettyRemotingServer, which will be considered for correction in the future.

Describe the Solution You'd Like

Add the ACTIVE event only for NettyRemotingClient.

Describe Alternatives You've Considered

Address the semantics of CONNECT and ACTIVE in NettyRemotingServer.

Additional Context

No response
@drpmma drpmma changed the title [Enhancement] Add channelActive for NettyRemotingClient#NettyConnectManageHandler [Enhancement] Introduce a new event NettyEventType.ACTIVE for ChannelEventListener Oct 23, 2023
drpmma added a commit to drpmma/rocketmq that referenced this issue Oct 23, 2023
@drpmma
[ISSUE apache#7493] Introduce a new event NettyEventType.ACTIVE for C…
2fd7cb8 
…hannelEventListener

* introduce a new event NettyEventType.ACTIVE,

* implement channelActive interface for NettyRemotingClient#NettyConnectManageHandler

* add onChannelActive for ChannelEventListener interface.
@drpmma drpmma mentioned this issue Oct 23, 2023
Merged
drpmma added a commit that referenced this issue Oct 24, 2023
@drpmma
[ISSUE #7493] Introduce a new event NettyEventType.ACTIVE (#7494)
2043dd5 
* [ISSUE #7493] Introduce a new event NettyEventType.ACTIVE for ChannelEventListener

* introduce a new event NettyEventType.ACTIVE,

* implement channelActive interface for NettyRemotingClient#NettyConnectManageHandler

* add onChannelActive for ChannelEventListener interface.

* Move send heartbeat to onChannelActive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #7493] Introduce a new event NettyEventType.ACTIVE drpmma/rocketmq
1 participant
@drpmma