Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] should dataReadAheadEnable default be true? #6940

Closed
3 tasks done
yuz10 opened this issue Jun 25, 2023 · 2 comments · Fixed by #6944
Closed
3 tasks done

[Bug] should dataReadAheadEnable default be true? #6940

yuz10 opened this issue Jun 25, 2023 · 2 comments · Fixed by #6944
Labels
type/bug

Comments

@yuz10
Copy link
Member

yuz10 commented Jun 25, 2023

Before Creating the Bug Report

  • I found a bug, not just asking a question, which should be created in GitHub Discussions.

  • I have searched the GitHub Issues and GitHub Discussions of this repository and believe that this is not a duplicate.

  • I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.

Runtime platform environment

Ubuntu 20.04

RocketMQ version

5.1.3

JDK Version

1.8

Describe the Bug

Before #6336 [RIP-62] Cold Read Control, the default value of madvice is MADV_NORMAL. after RIP-62, the default value changes to MADV_RANDOM. so I think the default value of dataReadAheadEnable should be true, to keep the same with old RocketMQ versions.

Steps to Reproduce

start new version of RocketMQ.

What Did You Expect to See?

madvice MADV_RANDOM is not called.

What Did You See Instead?

madvice MADV_RANDOM is called.

Additional Context

https://github.com/apache/rocketmq/blob/develop/store/src/main/java/org/apache/rocketmq/store/CommitLog.java#L149
@yuz10 yuz10 added the type/bug label Jun 25, 2023
@RongtongJin
Copy link
Contributor

+1，OS read ahead should be turned on by default.

@yuz10 yuz10 mentioned this issue Jun 25, 2023
Merged
RongtongJin pushed a commit that referenced this issue Jun 26, 2023
@yuz10
[ISSUE #6940] change dataReadAheadEnable default to false (#6944)
f3ce3e8 
* [ISSUE #6390] Add break to the exception of WHEEL_TIMER_NOT_ENABLE.

* fix broker start fail if mapped file size is 0

* log

* only delete the last empty file

* change dataReadAheadEnable default to true
@iamgd67
Copy link
Contributor

iamgd67 commented Oct 18, 2024

不开readAhead会严重影响slave同步冷数据速度

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #6940] change dataReadAheadEnable default to false yuz10/rocketmq
3 participants
@iamgd67 @yuz10 @RongtongJin