Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support batch ack when reput buffer ak to store in PopBufferMergeService #6797

Closed
1 task done
DongyuanPan opened this issue May 23, 2023 · 0 comments · Fixed by #6798
Closed
1 task done

Comments

@DongyuanPan
Copy link
Contributor

Before Creating the Enhancement Request

  • I have confirmed that this should be classified as an enhancement rather than a bug/feature.

Summary

If enablePopBufferMerge is enabled, CK and AK will be matched first in memory. For CKs that do not match exactly, a message needs to be sent and stored in the Revive Topic after a timeout. At this time, when some messages in a batch of messages in the CK have been ACKed, but the departmental messages have not been ACKed, it is necessary to generate a message for the ACKed messages and send it to the REVIVE Topic. In this case, if there are N messages that have been ACKed, you need to send N messages to the Revive topic. This leads to a large number of messages being rotated in MQ, and we can make some optimizations here.

Motivation

Support batch ACK to reduce the number of message rotation.
For a batch of messages in CK, when some messages have been ACKed and some messages have not been ACKed. We only send one message to the revive topic to indicate all ACKed messages. Therefore, this message needs to store the indexes of all ACKed messages. And in the PopReviveService, the corresponding processing.

Describe the Solution You'd Like

Support batch ack

Describe Alternatives You've Considered

Support batch ack

Additional Context

No response

ShannonDing pushed a commit that referenced this issue May 24, 2023
…fferMergeService (#6798)

* add back for PopReviveService

* add batch ack for PopReviveService
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant