Specify locale for case conversion #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michael-o English or like we have in Doxia ROOT ? |
michael-o
reviewed
Dec 4, 2024
| } | ||
|
|
||
| // nohelp == true | ||
| assertFalse(str.toUpperCase().contains("/HELP-DOC.HTML")); | ||
| assertFalse(str.toUpperCase(Locale.ENGLISH).contains("/HELP-DOC.HTML")); |
There was a problem hiding this comment.
Is this really uppercase, that looks weird...
There was a problem hiding this comment.
Could go either way.
assertFalse(str.toLowerCase(Locale.ENGLISH).contains("/help-doc.html"));
is semantically equivalent. Probably just the preference of whoever first wrote this line of code.
This is unrelated to Doxia. Here both English and |
slachiewicz
approved these changes
Dec 4, 2024
rreich
added a commit
to CoreMedia/maven-javadoc-plugin
that referenced
this pull request
Feb 17, 2025
…a-update-3.12.0 * commit 'dc085593a39b845805ccbd04078c782bc1859275': (162 commits) [MJAVADOC-824] remove output-configuration.apt.vm (apache#349) Specify locale for case conversion (apache#345) Replace two deprecated methods (apache#347) Replace some deprecated FileUtils methods (apache#340) [maven-release-plugin] prepare for next development iteration [maven-release-plugin] prepare release maven-javadoc-plugin-3.11.2 use github for scm Bump com.thoughtworks.qdox:qdox from 2.1.0 to 2.2.0 [MJAVADOC-823] legacyMode keeps using module-info.java (-sourcedirectory still use as well as java files input) (apache#343) Bump commons-io:commons-io from 2.17.0 to 2.18.0 Migrate from Plexus to Sisu Guice (apache#341) Remove usages of deprecated ReaderFactory class (apache#339) [MJAVADOC-814] handle parameters such packages with multi lines (apache#337) refactor: Replace Plexus AbstractLogEnabled with SLF4J (apache#338) [MJAVADOC-822] skippedModules should be more scalable and support regex (apache#336) Bump org.codehaus.mojo:l10n-maven-plugin from 1.0.0 to 1.1.0 [maven-release-plugin] prepare for next development iteration [maven-release-plugin] prepare release maven-javadoc-plugin-3.11.1 [MJAVADOC-821] Align toolchain discovery code with Maven Compiler Plugin [MJAVADOC-820] [REGRESSION] MJAVADOC-787 was merged incompletely ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://stackoverflow.com/questions/11063102/using-locales-with-javas-tolowercase-and-touppercase