Skip to content

Ignore duckdb test #1918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025
Merged

Ignore duckdb test #1918

merged 1 commit into from
Apr 15, 2025

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Apr 15, 2025

Rationale for this change

Intermediate fix while the test is broken, reported in duckdb/duckdb-iceberg#185

Are these changes tested?

Are there any user-facing changes?

@kevinjqliu
Copy link
Contributor

unblocks CI :)

@Fokko Fokko merged commit eb8756a into apache:main Apr 15, 2025
7 checks passed
@Fokko
Copy link
Contributor Author

Fokko commented Apr 15, 2025

unblocks CI :)

Indeed! :D

Thanks for the quick review @kevinjqliu 🙌

@Fokko Fokko deleted the fd-ignore-test branch April 15, 2025 18:41
kevinjqliu added a commit to kevinjqliu/iceberg-python that referenced this pull request Apr 17, 2025
Fokko pushed a commit that referenced this pull request Apr 17, 2025
<!--
Thanks for opening a pull request!
-->

<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->

# Rationale for this change
Issue is fixed upstream,
duckdb/duckdb-iceberg#185

This reverts commit eb8756a. (#1918)

# Are these changes tested?

# Are there any user-facing changes?

<!-- In the case of user-facing changes, please add the changelog label.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants