Documented row_filter expressions
#1862
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
reviewed
Apr 4, 2025
Fokko
reviewed
Apr 4, 2025
Co-authored-by: Fokko Driesprong <fokko@apache.org>
Co-authored-by: Fokko Driesprong <fokko@apache.org>
Fokko
reviewed
Apr 4, 2025
Fokko
reviewed
Apr 4, 2025
Fokko
reviewed
Apr 4, 2025
Fokko
reviewed
Apr 4, 2025
Fokko
reviewed
Apr 4, 2025
Fokko
approved these changes
Apr 4, 2025
There was a problem hiding this comment.
Thanks @norton120 I think this is a great addition to the docs 🙌 I left some small suggestions, let me know what you think of it 👍
Co-authored-by: Fokko Driesprong <fokko@apache.org>
Co-authored-by: Fokko Driesprong <fokko@apache.org>
Co-authored-by: Fokko Driesprong <fokko@apache.org>
norton120
force-pushed
the
string-parsing-docs
branch
from
5b347e4 to
21b6196
Compare
|
bah 🤦🏻 I clobbered the in-GH changes while rebasing main. grr. |
|
Sorry these last fixes took so long I missed the notifications. Updated! |
|
@norton120 no worries, thanks for following up! 🙌 |
Fokko
reviewed
Apr 15, 2025
There was a problem hiding this comment.
@norton120 I have two more minor issues while going over it
Comment on lines
+215
to
+216
| ```python | ||
|
|
There was a problem hiding this comment.
Suggested change
| ```python | |
| ```python |
| age_equals_18 = EqualTo("age", 18) | ||
|
|
||
| # This will raise a TypeError if the field type doesn't match | ||
| age_equals_18 = EqualTo("age", "18") # Will fail if age is an integer field |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
scan's
row_filterparam is not super intuitive. I got tired of reading over the expression and parser code as I'm trying to build out statements, so I had some docs made up.Are these changes tested?
They are docs only, so not really?
Are there any user-facing changes?
Yes there are docs for the expression and string syntaxes of
row_filternow.