Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing default_capacity to capacity for issue 47800 #48032

Merged
merged 12 commits into from
Mar 22, 2025
Merged

Changing default_capacity to capacity for issue 47800 #48032

merged 12 commits into from
Mar 22, 2025

Conversation

jroachgolf84
Copy link
Contributor

This PR aims to rename the triggerer's default_capacity value to be called capacity. This was originally outlined in issue #47800 by @RNHTTR.

Changes

  1. All instances of default_capacity were changed to capacity.
  2. The appropriate configuration files and tests were updated and tested locally.

Related Issue

closes: #47800

jedcunningham
jedcunningham reviewed Mar 21, 2025
View reviewed changes
jroachgolf84 and others added 4 commits March 21, 2025 13:27
@jroachgolf84
Re-working chart to only include the default_capacity. default_capaci…
23976f9 
…ty will be renamed capacity in Airflow 3.0, but this change maintains compability with Airflow 2.X, and would acutally allow 3.0 to fall back on this value if needed.
@jroachgolf84
Rebasing for airflow-core
7791b67
@jroachgolf84
Merge branch 'main' into issue-47800
a545d2a
@jroachgolf84
Merge branch 'main' into issue-47800
2a2b64e
jedcunningham
jedcunningham reviewed Mar 21, 2025
View reviewed changes
jedcunningham
jedcunningham reviewed Mar 22, 2025
View reviewed changes
@jedcunningham
Copy link
Member

Merging. Static check failure is unrelated.

@jedcunningham jedcunningham merged commit 14e1572 into apache:main Mar 22, 2025
56 of 57 checks passed
shubham-pyc pushed a commit to shubham-pyc/airflow that referenced this pull request Mar 22, 2025
@jroachgolf84 @shubham-pyc
Changing triggerer config option default_capacity to capacity (ap…
fa3e349 
…ache#48032)
@jedcunningham jedcunningham mentioned this pull request Mar 29, 2025
Closed
62 tasks
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
@jroachgolf84 @nailo2c
Changing triggerer config option default_capacity to capacity (ap…
9debff5 
…ache#48032)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedcunningham jedcunningham jedcunningham approved these changes

@dstandish dstandish Awaiting requested review from dstandish dstandish is a code owner

@hussein-awala hussein-awala Awaiting requested review from hussein-awala hussein-awala is a code owner

Assignees
No one assigned
Labels
area:helm-chart Airflow Helm Chart area:Triggerer
Projects
None yet
Milestone
Airflow Helm Chart 1.16.0
Development

Successfully merging this pull request may close these issues.

Rename the triggerer's default_capacity config to just capacity
2 participants
@jroachgolf84 @jedcunningham