Fix require_confirmation_dag_change

[sowow359]

Currently require_confirmation_dag_change seems to have no effect on pause/resume switch, triggering the switch will cause confirmation window to show up regardless.

This is caused by JS type conversions. In current version with data-require-confirmation="{{ appbuilder.require_confirmation_dag_change }}" resulting value on JS side in onChange function has String type and does not automatically converts to boolean, which causes incorrect check:

...
const requireConfirmation = $input.data("require-confirmation");  // has String type, non-empty
if (requireConfirmation) { // evaluates to true on non-empty strings
...

Adding lower on jinja side does the trick and seems like simplest fix, resulting string successfully converts to boolean. After that confirmation window shows up only when passing True to require_confirmation_dag_change.

---

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

• Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
• Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
• Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: dev@airflow.apache.org
  Slack: https://s.apache.org/airflow-slack

[pierrejeambrun]

Thank you for the pull request.

That seems a little odd that the normal string "Something" is considered a string (most things are then truthy), but casting it to lower somehow convert that to a boolean, I would think that this would remain a string something and the problem would stay.

I'll take a closer look tomorrow. I couldn't find the time today, I'll check it the next few days, thank you for your patience.

[pierrejeambrun]

Ok, as I recall html attribute values are string, therefore, we end up with attribute='True' or attribute='False'.

Which does not work indeed, both are truthy.

Jquery has method is smart enought to convert a js string bool into an actual bool ('true', 'false'), but he does not recognize python bool of course i.e 'True' 'False' which remain strings. This is why casting to lower solves the issue.

The problem is that this is too implicit. People reading that code will not understand why it's here in a couple of weeks and will have to get back here. I would prefer something more explicit like we do with checked attribute. Also usually the convention is if a boolean attribute is present then it's true, otherwise it's false, independently of its value. For instance just checked is enough, no need to checked='true'.

I would only set the attribute if True like this:

     {{ "data-require-confirmation" if appbuilder.require_confirmation_dag_change else "" }}

Then adapt the jquery query to check if the attribute is set or not, something like:

  const requireConfirmation = $input.is("[data-require-confirmation]");

[pierrejeambrun]

Looking good.

Working as expected ty.

[boring-cyborg]

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

[bbovenzi]

We'll need to cherry pick this for v2-10-test.

[pierrejeambrun]

Yes! I’ll open the PR tomorrow

edit: #42211