fix(cdk/menu): close sibling triggers when opening a menu #30894
+43
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistrykaran91
requested review from
adolgachev and
crisbeto
and removed request for
a team
mistrykaran91
force-pushed
the
fix/cdk-menu-screen-freeze-issue
branch
6 times, most recently
from
5a9dafd to
63bd6a1
Compare
Currently, when any sibling menu is opened then it overlaps and in cases it makes the screen unresponsive. This fix will close any sibling menu if its open Fixes angular#30881
mistrykaran91
force-pushed
the
fix/cdk-menu-screen-freeze-issue
branch
from
63bd6a1 to
269e23c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when any sibling menu is opened then it overlaps and in cases it freezes and makes the screen unresponsive. This fix will close any sibling menu if its open.
BREAKING CHANGE:
ContextMenuTrackerto filesrc/cdk/menu/menu-trigger-base.tsso that it is at the common location for both the menu triggers.ContextMenuTrackertoMenuTrackerso that can be used by bothCdkMenuTriggerandCdkContextMenuTrigger.Fixes #30881