Add taggingLabel for single and multiple select

[viniciusdacal]

issue #938

[LeleDev]

Please merge this one soon...

[brianfeister]

Sorry but there are so many issues to backtrack that I can't find the original, can you post a Plunkr demonstrating the bug so I can verify this fixes it? Maybe there already is a demo of the problem but I can't find it and would like to have it documented here for future reference. Thanks @viniciusdacal

[viniciusdacal]

In this first Plunkr you can see the error.
http://plnkr.co/edit/7tPA05od2FUCbZRqj8UY?p=preview
Just try to add a new item in the single select, It should show a label, but nothing happens.
In the multiple select, try to type "Adam" and you will get the follow error:
Error: [ngRepeat:dupes] Duplicates in a repeater are not allowed. Use 'track by' expression to specify unique keys. Repeater: person in $select.items track by person.name, Duplicate key: Adam

On this follow Plunkr, I just add my current version of select.js with the fixes.
http://plnkr.co/edit/bG7yvD8YotzwexvSHti0?p=preview

Thanks @brianfeister

[ghost]

@brianfeister, as this pull request fixes a critical function (taging on single select), can you allocate the time for merging it to master ?

[manichandra]

+1

[kshutkin]

#1006

[viniciusdacal]

@brianfeister any news about it?

[yaojingguo]

+1

[MartinNuc]

+1

[eranimo]

+1

[rodrigogoncalves]

+1

[eric-norcross]

+1

[Nekmo]

+1

[valloq]

+1

[cojack]

Anything new?

[bwilson-ux]

+1

[fferraris]

+1

[mg-agilion]

+1

[capic]

👍

[bryanstetson]

+1

[isery]

+1

[rodrigogoncalves]

Is there anything I could do to help having this PR merged?

[neoned]

any news about it?

[jkevingutierrez]

Any news ?

[MartinNuc]

We forked viniciusdacal's version and use it for like 6 months already.

[karlr42]

As was mentioned here for me the easiest workaround was just to use a regular multiple with tagging and set limit="1".

[wesleycho]

This needs rebasing.

Linking issue this fixes - #972.

[viniciusdacal]

thanks @wesleycho.
I will work on this.

[viniciusdacal]

@wesleycho updated.

[viniciusdacal]

any news about the revision?

[user378230]

There are still conflicts apparently, can you rebase again?
Does the copy and paste include all changes that have gone into the uiSelectMultipleDirective keyup handler since you last did it?
Are there no associated tests?

[viniciusdacal]

@user378230 when I rebase my branch last time, I got the current code and added the changes again. so, this code has all changes from the day I rebased.

[jpkleemans]

+1

[user378230]

@user378230 when I rebase my branch last time, I got the current code and added the changes again. so, this code has all changes from the day I rebased.

Thats fine, just still need to make sure no changes are dropped prior to commit of copy-paste.

This still needs test(s), rebasing, example updating & squashing though. Once that is done, I'll merge.

Thanks for your patience and hard work! 👍

[Teegrounet]

I think you should add : ctrl.taggingLabel = '(new)'; in controller
Without this, if taggingLabel attribute doesn't exist ctrl.taggingLabel is not initialized and newItem = ctrl.search+' '+ctrl.taggingLabel; -> ctrl.search+' '+ undefined

There is a difference between single and multiple mode : in single a compare function with case insensitive is used and in multiple mode angular.equals (sensitive function) is used