-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Improve semantics / architecture of bootstrap templates #537
Conversation
Fixes the group-by example and switches to attribute allow-clear
Adds more targetable classes .ui-select-placeholder .ui-select-match-text .ui-select-clear
Thanks for this @koorb, hopefully I'll have time to look into it soon. In the meantime, the build task and tag for a release is done by a repo owner since not every merge is guaranteed to be a release. Please remove the |
Sorry @brianfeister how do I remove those commits from this PR? |
No worries. I would start by pulling the latest from master and merging it into your local branch, then do a hard reset http://stackoverflow.com/questions/7147270/how-can-i-make-an-hard-reset-of-a-single-file of the files in |
make sure to also revert the changes to |
Do I need to submit a new PR? |
If you push the changes to your branch the rest is automatic Sent from my iPhone
|
@koorb - are you good to go? Sorry for my brief email reply yesterday - all you do is make the changes, save a new commit, and then push that commit to your existing branch, Github will take care of the rest. |
This reverts commit 1689ccf.
Right @brianfeister I did it again but I've reverted it too. Starting to get the hang of how this works! |
Improve semantics / architecture of bootstrap templates
Hey @koorb - thanks again for this. I found that your direction didn't work for the multi select permutation of the directive. Thanks for your pointers though, v0.9.6 includes some of what you did here and apologies for not including it, seemed like more to back out than to include. |
Thats fine @brianfeister it was my first pull request and I got it in a bit of a mess, but glad it was useful. |
Right now the bootstrap templates end up looking clunky and they have no identifiable classes so are impossible to restyle. This set of changes removes the
col-
classes and adds targetable classes.ui-select-placeholder
.ui-select-match-text
and.ui-select-clear
. It moves the caret and clear buttons into the the main toggle and allows the main toggle button to be disabled (which was a aesthetics more than functionality)