This repository was archived by the owner on Oct 2, 2019. It is now read-only.
Use object property of track by
for comparison
#420
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands on PR #256 to improve efficiency, clean up the code, and use
track by
in single as well as multiple configurations.RepeatParser
.track by
for comparisons in both single and multiple configuration.angular.equals
instead of==
for comparison. The AngularJSngOptions
directive notes that it compares by reference, not value, so it seems natural that angular-ui-select would do the same. However, several developers have posted issues on this behavior causing problems, so usingangular.equals
seems like a better choice. This change was made with a separate commit, so the rest of this PR could be merged without that commit.