Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(content): add website french translation #665

Merged
merged 1 commit into from
Sep 23, 2023

Conversation

Jad31
Copy link
Contributor

@Jad31 Jad31 commented Sep 22, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

Closes #

What is the new behavior?

  • Add new fr locale
  • Add full French translation to analogjs website.
  • Add french translation to docs sidenav.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Thanks @Villanuevand for your work on #644; it greatly assisted in integrating a new language!

@netlify
Copy link

netlify bot commented Sep 22, 2023

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 22b378a
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/650daab39419760008900c39
😎 Deploy Preview https://deploy-preview-665--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 22, 2023

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 22b378a
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/650daab3c6b0bc0007fff6c2
😎 Deploy Preview https://deploy-preview-665--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 22, 2023

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 22b378a
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/650daab3a00dbb0008db84b1
😎 Deploy Preview https://deploy-preview-665--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Villanuevand
Copy link
Contributor

Good job! @Jad31

@brandonroberts brandonroberts merged commit 57fa668 into analogjs:main Sep 23, 2023
@brandonroberts
Copy link
Member

Thanks! @allcontributors add @Jad31 for doc,translation

@allcontributors
Copy link
Contributor

@brandonroberts

I've put up a pull request to add @Jad31! 🎉

@besimgurbuz besimgurbuz mentioned this pull request Sep 27, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants