Add ethernet support to eval-pqmon #2550

romandariana · 2025-04-11T10:33:21Z

Pull Request Description

This PR adds support for the W5500 Ethernet controller chip, providing standard Ethernet connectivity for no-os projects. The implementation includes:

Core W5500 driver with SPI interface and socket management
Network interface adapter to integrate with the no-os network_interface API
IIO subsystem support for W5500-based network communications
Integration with the eval-pqmon project, adding a new "ethernet" build option

PR Type

New feature (change that adds new functionality)

PR Checklist

I have followed the Coding style guidelines
I have complied with the Submission Checklist
I have performed a self-review of the changes
I have commented my code, at least hard-to-understand parts
I have build all projects affected by the changes in this PR
I have tested in hardware affected projects, at the relevant boards
I have signed off all commits from this PR
I have updated the documentation (wiki pages, ReadMe etc), if applies

drivers/net/w5500/w5500.h

buha

add a builds.json

i see this project doesn't have one, but i would add it at this stage to ensure we don't break this project or the w5500 networking infrastructure

drivers/net/w5500/w5500.h

drivers/net/w5500/w5500.c

buha · 2025-04-14T09:00:47Z

and make sure to review the #ifdefs you added, they seem to break some existing projects that use networking

romandariana · 2025-04-14T13:47:04Z

I pushed a v2 with some fixes for now:

v1 -> v2

use /** instead of /*! doxygen syntax in header files
moved errno.h and string.h in the .c file, same for delay.h and alloc.h
instead of using network_interface.h, i refactored the driver to use driver specific structure for socket address to see if we get rid of some of the build errors this way. a low-level driver would better not depend on higher level network interface. the mapping between the two is done in w5500_network
updated the README.md file of the eval-pqmon project

Rename the "ethernet" build option to "ethernet_t1l" to clarify that it refers specifically to the ADIN1100 T1L Ethernet PHY. This change prepares for the future addition of WIZ850io (W5500-based) Ethernet support as an alternative interface option. Signed-off-by: Alisa-Dariana Roman <alisa.roman@analog.com>

Add low-level driver for the WIZnet W5500 Ethernet controller chip. The driver provides SPI interface communication, socket management, and TCP/UDP/MACRAW protocol implementations. Signed-off-by: Alisa-Dariana Roman <alisa.roman@analog.com>

Add adapter layer to integrate the W5500 Ethernet controller with the generic network_interface API. This enables the W5500 driver to be used with no-os TCP/IP socket implementations. Signed-off-by: Alisa-Dariana Roman <alisa.roman@analog.com>

Add W5500 Ethernet controller support to the IIO subsystem by extending the network interface conditionals to include NO_OS_W5500_NETWORKING. This allows applications to use W5500-based network connectivity for IIO communication alongside existing UART and LWIP options. Signed-off-by: Alisa-Dariana Roman <alisa.roman@analog.com>

Add support for standard Ethernet connectivity to the eval-pqmon project using the W5500 Ethernet controller. This introduces a new "ethernet" build option alongside the existing USB, serial, and ethernet_t1l options. Configure necessary hardware parameters, SPI interface, and network stack integration for the WIZ850io module. Signed-off-by: Alisa-Dariana Roman <alisa.roman@analog.com>

romandariana · 2025-04-16T09:12:42Z

v2 -> v3

add #ifdef NO_OS_W5500_NETWORKING to w5500_network files to avoid getting it built in random projects

buha · 2025-04-16T09:22:53Z

ok, i'm dropping the requirement to add builds.json at this point, that's a separate discussion because any build of this project requires pqlib and i am not sure we have the infrastructure now, that can be a separate pr

CiprianRegus · 2025-04-16T10:34:11Z

network/w5500_network/w5500_network.c

+	ret = w5500_socket_open(net_dev->mac_dev, new_physical_id, W5500_Sn_MR_TCP, 2);
+	if (ret)
+		return ret;
+
+	ret = w5500_socket_bind(net_dev->mac_dev, new_physical_id,
+				server_socket->local_port);
+	if (ret)
+		return ret;
+
+	ret = w5500_socket_listen(net_dev->mac_dev, new_physical_id);
+	if (ret)
+		return ret;


open, bind and listen should have been called for a server socket prior to accept(). Why is it necessary to add this sequence here?

CiprianRegus · 2025-04-16T10:58:01Z

network/w5500_network/w5500_network.c

+	new_socket = &net_dev->sockets[new_physical_id];
+	new_socket->sock_id = sock_id;
+	new_socket->local_port = server_socket->local_port;
+	new_socket->in_use = 1;
+	new_socket->role = W5500_ROLE_SERVER;
+
+	server_socket->sock_id = net_dev->next_virtual_id++;
+	server_socket->role = W5500_ROLE_CLIENT;


Can you please explain what is happening here? Are we changing the socket associated with the server?

If I understood correctly, in the iio module where accept is called, it expects a new client socket to be created and the server socket keeps listening for new connections. But for W5500, the socket that is listening changes status and becomes a "client" socket. To bypass this, in the w5500 accept function I created a new socket that will be the server socket, thus the 3 function callings above, then I switch the virtual ids. Should I extract this switch in another static function to make things clearer?

CiprianRegus · 2025-04-16T11:03:19Z

network/w5500_network/w5500_network.c

+
+	socket = &net_dev->sockets[physical_id];
+
+	socket->role = (proto == PROTOCOL_TCP) ? W5500_ROLE_CLIENT : W5500_ROLE_UNUSED;


I don't think you can know if the socket will be used by a client or server at this point

CiprianRegus · 2025-04-16T11:10:42Z

projects/eval-pqmon/src/examples/basic/basic_example.c

+	struct w5500_dev *mac_dev;
+	struct w5500_network_dev *net_dev;
+
+	status = w5500_init(&mac_dev, &w5500_ip);


I think you can move this part in the w5500_network_init() function in order to simplify the application code.

CiprianRegus · 2025-04-16T11:11:41Z

projects/eval-pqmon/src/common/common_data.c

+	.gpio_reset = w5500_rst_gpio_ip,
+	.gpio_int = w5500_int_gpio_ip,
+	.mac_addr = {0x00, 0x08, 0xDC, 0x01, 0x02, 0x03},
+	.ip_addr = {192, 168, 1, 110},


Is there a way to support DHCP besides the static IP assignment? Also, it would be nice if you could define a macro for the IP address and netmask (similarly to this approach: https://github.com/analogdevicesinc/no-OS/blob/main/projects/apard32690/Makefile#L13-L16 , however you can set it directly into the init param). I think that would provide a simple way of building the project with different ip addresses for the server.

romandariana requested review from buha, CiprianRegus, dbogdan, amiclaus, rbolboac and danmois as code owners April 11, 2025 10:33

buha reviewed Apr 14, 2025

View reviewed changes

drivers/net/w5500/w5500.h Outdated Show resolved Hide resolved

buha reviewed Apr 14, 2025

View reviewed changes

drivers/net/w5500/w5500.h Outdated Show resolved Hide resolved

drivers/net/w5500/w5500.c Show resolved Hide resolved

romandariana force-pushed the dev_pqmon_ethernet branch from 67f111d to 695a872 Compare April 14, 2025 13:42

romandariana added 5 commits April 16, 2025 12:06

drivers: network: add W5500

a74eeb3

Add low-level driver for the WIZnet W5500 Ethernet controller chip. The driver provides SPI interface communication, socket management, and TCP/UDP/MACRAW protocol implementations. Signed-off-by: Alisa-Dariana Roman <alisa.roman@analog.com>

romandariana force-pushed the dev_pqmon_ethernet branch from 695a872 to 8eb9d6e Compare April 16, 2025 09:08

CiprianRegus reviewed Apr 16, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ethernet support to eval-pqmon #2550

Add ethernet support to eval-pqmon #2550

romandariana commented Apr 11, 2025 •

edited

Loading

buha left a comment

buha commented Apr 14, 2025

romandariana commented Apr 14, 2025 •

edited

Loading

romandariana commented Apr 16, 2025

buha commented Apr 16, 2025

CiprianRegus Apr 16, 2025

CiprianRegus Apr 16, 2025

romandariana Apr 16, 2025 •

edited

Loading

CiprianRegus Apr 16, 2025

CiprianRegus Apr 16, 2025

CiprianRegus Apr 16, 2025


		socket = &net_dev->sockets[physical_id];

		socket->role = (proto == PROTOCOL_TCP) ? W5500_ROLE_CLIENT : W5500_ROLE_UNUSED;

Add ethernet support to eval-pqmon #2550

Are you sure you want to change the base?

Add ethernet support to eval-pqmon #2550

Conversation

romandariana commented Apr 11, 2025 • edited Loading

Pull Request Description

PR Type

PR Checklist

buha left a comment

Choose a reason for hiding this comment

buha commented Apr 14, 2025

romandariana commented Apr 14, 2025 • edited Loading

romandariana commented Apr 16, 2025

buha commented Apr 16, 2025

CiprianRegus Apr 16, 2025

Choose a reason for hiding this comment

CiprianRegus Apr 16, 2025

Choose a reason for hiding this comment

romandariana Apr 16, 2025 • edited Loading

Choose a reason for hiding this comment

CiprianRegus Apr 16, 2025

Choose a reason for hiding this comment

CiprianRegus Apr 16, 2025

Choose a reason for hiding this comment

CiprianRegus Apr 16, 2025

Choose a reason for hiding this comment

romandariana commented Apr 11, 2025 •

edited

Loading

romandariana commented Apr 14, 2025 •

edited

Loading

romandariana Apr 16, 2025 •

edited

Loading