Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npm backup issue #226 #315

Merged
merged 2 commits into from
Mar 6, 2023

Conversation

nick-The-One
Copy link
Contributor

This change solves issue #226 by using json format for dumping npm dependencies and parcing its keys — should be more robust than split by slash.

@nick-The-One
Copy link
Contributor Author

@alichtman Hey there! Could you take a look at this PR?

Copy link
Owner

@alichtman alichtman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the ping + patience. [Insert not enough time to do everything I want to do spiel].

I agree this PR is worthwhile. Thanks for taking the time to write it!

See the pointer to where changes are required for the reinstallation process. I'd love to have some automated end-to-end testing to make sure changes like this don't break anything.

Edit: Thought about it further; I'm not sure if any changes are required. Let me take another look when I get back to my computer. I wrote this code almost half a decade ago, and it's not super fresh in my mind anymore.

Edit 2: Yep, this seems to work as expected! Disregard v1 of my comments.

Cheers :)
Aaron

@alichtman alichtman changed the title fix npm backup issue #226 Fix npm backup issue #226 Mar 6, 2023
@alichtman alichtman merged commit 3d2f153 into alichtman:main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants