Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle piping commands properly #299

Merged
merged 8 commits into from
Dec 11, 2021
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 20 additions & 14 deletions shallow_backup/utils.py
Original file line number Diff line number Diff line change
@@ -1,41 +1,47 @@
import os
import subprocess as sp
from shlex import split
from shutil import rmtree, copytree
from typing import List, Union
from .printing import *


def run_cmd(command: str):
def run_cmd(command: Union[str, List]):
"""
Wrapper on subprocess.run to handle shell commands as either a list of args
or a single string.
"""
if not isinstance(command, list):
command = split(command)
output = None
try:
if not isinstance(command, list):
process = sp.run(command.split(), stdout=sp.PIPE, stderr=sp.DEVNULL)
return process
else:
process = sp.run(command, stdout=sp.PIPE, stderr=sp.DEVNULL)
return process
while "|" in command:
index = command.index("|")
first_command, command = command[:index], command[index + 1:]
output = sp.Popen(first_command, stdin=output.stdout if output else None, stdout=sp.PIPE, stderr=sp.DEVNULL)
return sp.run(command, stdout=sp.PIPE, stdin=output.stdout if output else None, stderr=sp.DEVNULL)
except FileNotFoundError: # If package manager is missing
return None


def run_cmd_write_stdout(command, filepath) -> int:
def run_cmd_write_stdout(command: str, filepath: str) -> int:
"""
Runs a command and then writes its stdout to a file.
Returns the returncode if the return value is not 0.
:param: command str representing command to run
:param: filepath str file to write command's stdout to
"""
process = run_cmd(command)
if process and process.returncode == 0:
with open(filepath, "w+") as f:
f.write(process.stdout.decode('utf-8'))
elif process:
print_path_red("An error occurred while running: $", command)
if process:
if process.returncode == 0:
with open(filepath, "w+") as f:
f.write(process.stdout.decode('utf-8'))
else:
print_path_red("An error occurred while running: $", command)

return process.returncode
else:
print_path_red("An error occurred while running: $", command)
print_yellow("Package manager not present.")
return -1


Expand Down