Loosen the restrictions around directly assignable expressions #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently only allow a subset of expressions to be used as the target of assignment. The Swift compiler also only allows a subset, but keeping track of their subset is hard. For example, in #321 we see that an optional expression can be used for assignment but we don't currently support that. Let's get out of that game. All expressions can be assignments now! Sure, that doesn't work for the real swift compiler, but that's not our circus, and furthermore, not our monkeys.
|
Well, that's a lot simpler than what I tried! Makes sense to me. Thanks so much for addressing this! |
nmote
added a commit
to semgrep/ocaml-tree-sitter-semgrep
that referenced
this pull request
Oct 9, 2023
In particular, pulling in alex-pinkus/tree-sitter-swift#324
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently only allow a subset of expressions to be used as the target of assignment. The Swift compiler also only allows a subset, but keeping track of their subset is hard. For example, in #321 we see that an optional expression can be used for assignment but we don't currently support that.
Let's get out of that game. All expressions can be assignments now! Sure, that doesn't work for the real swift compiler, but that's not our circus, and furthermore, not our monkeys.
Fixes #321